Django Polymorphic Stubs #15163
Django Polymorphic Stubs #15163
Conversation
This comment has been minimized.
This comment has been minimized.
huynguyengl99
force-pushed
the
feat/django-polymorphic
branch
from
37ef686 to
2168e07
Compare
This comment has been minimized.
This comment has been minimized.
…rride instance variable
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
Just a quick note: We need explanations for the possible types for Any, except for obvious cases (like dict[str, Any] or Model[Any]). But especially annotations like object: Any or **kwargs: Any need an explanation on why Any was used or what types are allowed. You can also leave these fields unannotated or use Incomplete where that is not possible for now.
|
Hi @srittau , thank you for your review. Initially, I planned to create this PR to help add type hints to the upstream package. However, after discussing this with the current project lead maintainer in jazzband/django-polymorphic#647, he prefers to add the types directly in the project, as this will be much more helpful in the long term. Because of that, I created this PR mainly to establish the initial types and to run our full type-checking workflow, ensuring the types are correct before submitting a PR back to that repository. That’s also the reason I haven’t linked an upstream issue to this PR yet. As a result, some |
|
In that case, it's best to just remove |
2 participants
No description provided.